The following document contains the results of FindBugs Report
FindBugs Version is 2.0.1
Threshold is
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Switch statement found in ch.aprconsulting.swx.mdigui.data.OrderBook.setEntry(OrderBookEntry) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 179 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new ch.aprconsulting.swx.mdigui.data.ReadTradedInstruments(Reader, boolean) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 92 | Medium |
| ch.aprconsulting.swx.mdigui.data.ReadTradedInstruments.RENEW_STRINGS isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 36 | High |
| Dereference of the result of readLine() without nullcheck in new ch.aprconsulting.swx.mdigui.data.ReadTradedInstruments(Reader, boolean) | STYLE | NP_DEREFERENCE_OF_READLINE_VALUE | 59 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| ch.aprconsulting.swx.mdigui.data.TradesTableModel$1.run() uses the same code for two branches | STYLE | DB_DUPLICATE_BRANCHES | 123 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in ch.aprconsulting.swx.mdigui.data.UDPListener.listenToUDP(ListenerModel, Console, TradesTableModel): new String(byte[], int, int) | I18N | DM_DEFAULT_ENCODING | 193 | High |
| ch.aprconsulting.swx.mdigui.data.UDPListener.listenToUDP(ListenerModel, Console, TradesTableModel) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 281 | Medium |
| Result of integer multiplication cast to long in ch.aprconsulting.swx.mdigui.data.UDPListener.listenToUDP(ListenerModel, Console, TradesTableModel) | STYLE | ICAST_INTEGER_MULTIPLY_CAST_TO_LONG | 163 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Invocation of toString on values() in ch.aprconsulting.swx.mdigui.enums.UpdateAction.fromFixValue(char) | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 34 | Medium |
| Invocation of toString on values() in ch.aprconsulting.swx.mdigui.enums.UpdateAction.fromFixValue(MDUpdateAction) | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 41 | Medium |
| Invocation of toString on values() in ch.aprconsulting.swx.mdigui.enums.UpdateAction.fromFixValue(MDUpdateAction) | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 49 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| ch.aprconsulting.swx.mdigui.gui.OrderBookPanel.init() does not release lock on all exception paths | MT_CORRECTNESS | UL_UNRELEASED_LOCK_EXCEPTION_PATH | 220 | Medium |
| ch.aprconsulting.swx.mdigui.gui.OrderBookPanel.update(Observable, OrderBookEntry) does not release lock on all exception paths | MT_CORRECTNESS | UL_UNRELEASED_LOCK_EXCEPTION_PATH | 324 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in ch.aprconsulting.swx.mdigui.gui.Ticker.main(String[]): new java.io.FileReader(String) | I18N | DM_DEFAULT_ENCODING | 513 | High |
| ch.aprconsulting.swx.mdigui.gui.Ticker.verbose isn't final and can't be protected from malicious code | MALICIOUS_CODE | MS_CANNOT_BE_FINAL | 171 | Medium |
| Write to static field ch.aprconsulting.swx.mdigui.gui.Ticker.textArea from instance method new ch.aprconsulting.swx.mdigui.gui.Ticker(SenderInfo) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 338 | Medium |
| Write to static field ch.aprconsulting.swx.mdigui.gui.Ticker.title from instance method new ch.aprconsulting.swx.mdigui.gui.Ticker(SenderInfo) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 189 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| ch.aprconsulting.swx.mdigui.gui.Ticker$2.actionPerformed(ActionEvent) invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 218 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should ch.aprconsulting.swx.mdigui.gui.Ticker$MyTextArea be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 543 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of ch.aprconsulting.swx.mdigui.data.OrderBookEntry.getEntryTime(), which is known to be non-null in ch.aprconsulting.swx.mdigui.gui.TradesChartPanel.addNewTrade(OrderBookEntry) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 122 | Medium |
| Redundant nullcheck of ch.aprconsulting.swx.mdigui.data.OrderBookEntry.getEntryTime(), which is known to be non-null in ch.aprconsulting.swx.mdigui.gui.TradesChartPanel.createPriceSeries(List) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 67 | Medium |
| Redundant nullcheck of ch.aprconsulting.swx.mdigui.data.OrderBookEntry.getEntryTime(), which is known to be non-null in ch.aprconsulting.swx.mdigui.gui.TradesChartPanel.createQuantitySeries(List) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 80 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from quickfix.Message to quickfix.swx.MarketDataSnapshotFullRefresh in ch.aprconsulting.swx.mdigui.handler.MarketDataFullRefreshHandler.handle(OrderBooks, TradesTableModel, Message) | STYLE | BC_UNCONFIRMED_CAST | 110 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should ch.aprconsulting.swx.mdigui.handler.MarketDataFullRefreshHandler$BookDepthCounter be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 44 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from quickfix.Message to quickfix.swx.MarketDataIncrementalRefresh in ch.aprconsulting.swx.mdigui.handler.MarketDataIncrementRefreshHandler.handle(OrderBooks, TradesTableModel, Message) | STYLE | BC_UNCONFIRMED_CAST | 43 | Medium |
| Redundant nullcheck of book, which is known to be non-null in ch.aprconsulting.swx.mdigui.handler.MarketDataIncrementRefreshHandler.handle(OrderBooks, TradesTableModel, MarketDataIncrementalRefresh) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 132 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from quickfix.Message to quickfix.swx.SecurityStatus in ch.aprconsulting.swx.mdigui.handler.SecurityStatusHandler.handle(OrderBooks, TradesTableModel, Message) | STYLE | BC_UNCONFIRMED_CAST | 31 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from quickfix.Message to quickfix.swx.TradingSessionStatus in ch.aprconsulting.swx.mdigui.handler.TradingSessionStatusHandler.handle(OrderBooks, TradesTableModel, Message) | STYLE | BC_UNCONFIRMED_CAST | 28 | Medium |
